CmdPal: Fix dock band activation lifecycle - #49739
Open
Jiří Polášek (jiripolasek) wants to merge 1 commit into
Open
CmdPal: Fix dock band activation lifecycle#49739Jiří Polášek (jiripolasek) wants to merge 1 commit into
Jiří Polášek (jiripolasek) wants to merge 1 commit into
Conversation
Jiří Polášek (jiripolasek)
added
Product-Command Palette
Jiří Polášek (jiripolasek)
force-pushed
the
dev/jpolasek/f/cmdpal-fix-dock-band-activation-lifecycle
branch
from
August 7, 2026 05:18
1fafc3a to
e594b64
Compare
Jiří Polášek (jiripolasek)
requested review from
Michael Jolley (michaeljolley) and
Mike Griese (zadjii-msft)
August 7, 2026 13:16
Michael Jolley (michaeljolley)
left a comment
Michael Jolley (michaeljolley)
left a comment
Contributor
There was a problem hiding this comment.
DockBandViewModel.InitializeFromList is scheduling an async UI update. Since cleanup can finish before it runs, should we add a check of the cleanup state in the UI callback or serialize initialization and cleanup?
Collaborator
Author
The other pancake (#49742) addresses this |
Michael Jolley (michaeljolley)
approved these changes
Aug 8, 2026
- Remembers the exact IListPage used for the ItemsChanged subscription, so we have muching unsubscribe. - Serializes initialization and cleanup to prevent late subscriptions. - Derives Performance Monitor load state from active subscribers, so our decisions now follow the real world state. - Prevents widget activation counts from underflowing during Dock rebuilds. - Adds regression tests for activation transitions and cleanup races.
Michael Jolley (michaeljolley)
force-pushed
the
dev/jpolasek/f/cmdpal-fix-dock-band-activation-lifecycle
branch
from
August 9, 2026 18:56
e594b64 to
d370908
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This PR improve handling of the dock band life cycle, with PerfMon benefiting from this - it should reduce risk of bands being stuck.